Closed liaham closed 4 months ago
@liaham Could you update your pull request accordingly, please? So, I can merge it?
Hi @picman, there is nothing to update. I made the pull request at January 30th. Your last commit on devel was on January 9th. Or did I oversee something?
I suggest modifying your pull request as follows:
if dmsf_link.dmsf_folder
!dmsf_link.dmsf_folder.visible? || !DmsfFolder.permissions?(dmsf_link.dmsf_folder, allow_system: false)
--elsif dmsf_link.project
-- !dmsf_link.project.dmsf_available?
++ else
++ !dmsf_link.project&.dmsf_available?
end
Thank you!
This change stablizes the query with DmsfLink objects since they could have stored a project_id of -1 causing a nil error.
This may happen when the linking of a dms document with an issue was not successful or aborted as observed with https://github.com/danmunn/redmine_dmsf/pull/1466.