search

dann-merlin / Spotipyne

Gtk Spotify client written in python made to be compatible with mobile formfactors like a pinephone.
GNU General Public License v3.0
12 stars 2 forks source link

Some details that would be nice to fix #1

Open Suzamax opened 4 years ago

Suzamax commented 4 years ago

Hey, nice work! I really appreciate it :smile:

By the way, there's a detail I have observed: the device and heart icons aren't displayed on Pop OS 20.10 (maybe in Fedora too), so I suppose you're not using Adwaita, are you? I don't know if this is an issue on my machine or a bad config.

Keep up the hard work! I'd like to help but I'm bad at Python at the moment.

dann-merlin commented 4 years ago

That's weird. I am using the Adwaita Dark theme myself, but it should AFAIK just use the default theme, that is installed. I actually want to look into rewriting the gtk stuff to gtk4, but I haven't looked into that yet and it might be a while, as I don't have the time atm. But that might fix the problem. There seem to be a lot of different ways to use icons with the python gtk3 library and I hope it's better with gtk4.

Thanks for the issue and the kind words! (I'm bad in Python as well, lol, but I failed with rust and I wanted the libhandy and a spotify library)

Suzamax commented 4 years ago

No no, I mean the icon theme (I personally use Pop). I wouldn't think about using GTK4 at the moment, because it's more important to give features to the program rather than changing its framework.

You're welcome :-)

PS: I gave up on Vala, I do have a repo for a Telegram GTK client written in that language, but I'm currently learning GTKMM (GTK for C++) for it, leaving behind the Elementary-focused idea and giving it a more GTK-global view.

El jue, 29 de oct de 2020 a las 08:14, dann-merlin notifications@github.com escribió:

That's weird. I am using the Adwaita Dark theme myself, but it should AFAIK just use the default theme, that is installed. I actually want to look into rewriting the gtk stuff to gtk4, but I haven't looked into that yet and it might be a while, as I don't have the time atm. But that might fix the problem. There seem to be a lot of different ways to use icons with the python gtk3 library and I hope it's better with gtk4.

Thanks for the issue and the kind words! (I'm bad in Python as well, lol, but I failed with rust and I wanted the libhandy and a spotify library)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dann-merlin/Spotipyne/issues/1#issuecomment-718820197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACO4ZZNKSAA3C75WWVY5KF3SNGBEBANCNFSM4TC6Q7IA.

dann-merlin commented 3 years ago

Yes, you are a 100% correct, haha. I'll keep an eye on you project. Sounds cool!