search

dannagle / PacketSender

Network utility for sending / receiving TCP, UDP, SSL, HTTP
https://packetsender.com
GNU General Public License v2.0
2.38k stars 370 forks source link

Initial implementation of a preview dialog #254

Closed zethon closed 3 years ago

zethon commented 3 years ago

I fooled around with different buttons and different locations but I could not come up with anything too pleasing. Instead I added double-click handlers to the two QLineEdits. I know they're pretty intertwined but I decided to give each one its own handler just in case they are ever unequal.

Here is what the preview dialog looks like.

image

If you have any different suggestions about where to put a Preview button or any other suggestions please let me know.

dannagle commented 3 years ago

It may be a week or so before I can look at this patch. As a hunch, I think double-click handlers may work. I don't remember binding them to anything.

zethon commented 3 years ago

Normally on a QLineEdit a double-click will Select All.

dannagle commented 3 years ago

Thanks for the addition.

I merged and then made some changes. I made it so the preview popup supports editing if you double-click the ascii line.