[BUG] The version is always shown as 8.0.6

dannagle / PacketSender

Network utility for sending / receiving TCP, UDP, SSL, HTTP

https://packetsender.com

GNU General Public License v2.0

2.39k stars 372 forks source link

[BUG] The version is always shown as 8.0.6 #324

Closed eribertomota closed 1 year ago

eribertomota commented 1 year ago

What OS and Version?

Debian 12

Description of issue

In menu bar, click over Help > About. Is possible to see: PS Version 8.0.6.

dannagle commented 1 year ago

Version is assigned during build time with my offline pipeline that code-signs. If the build is good, I tag it and push the tags.

You make a really good point though. That workflow causes the version to be disconnected from the source code.

I should instead commit the modified version files, tag, and then push.

I will leave this issue open until I can do that.

dannagle commented 1 year ago

The pipeline still bumps the version, which is needed for iterative tests, but my workflow now allows a commit and push with the final version number. It's a workable middle ground. Closing this issue.