style(pre-commit): apply the init pre-commit fixup - Githubissues

dannf / ubuntu-server-netboot

Other

46 stars 9 forks source link

style(pre-commit): apply the init pre-commit fixup #17

Closed tai271828 closed 3 years ago

tai271828 commented 3 years ago

Types of changes

Refactoring

Description

Follow the discussion of this thread https://github.com/dannf/ubuntu-server-netboot/pull/15#issuecomment-831274714 Let's add pre-commit and apply bllack fix.

Checklist:

[ ] Add test cases to all the changes you introduce
[ ] Run poetry run pytest locally to ensure all linter checks pass
[ ] Update the documentation if necessary

Steps to Test This Pull Request

The same as the testing method from Follow the discussion of this thread https://github.com/dannf/ubuntu-server-netboot/pull/15#issuecomment-831274714 Let's add pre-commit and apply bllack fix.

tai271828 commented 3 years ago

Thanks @tai271828 ! This will really help consistency! Would you mind mentioning black and flake8 in the commit message? It currently just mentions the use of pre-commit, which is kinda burying the lead :) And just one question inline.

uh, sounds good. Will do!

tai271828 commented 3 years ago

I have updated the commit message according to the above discussion/suggestion, and this pull request is ready to review again.