dannf / ubuntu-server-netboot

Other
46 stars 9 forks source link

Introduce poetry python package management tool #20

Closed tai271828 closed 3 years ago

tai271828 commented 3 years ago

Types of changes

Description

Per our discussion on MM, we will poetry to manage ubuntu-server-netboot as a python package for the distribution purpose later, and development of test cases.

Checklist:

Steps to Test This Pull Request

Follow the updated README and it should generate the same content of grub.cfg as what its previous codebase does. What the only change a user will be aware of is the command name migrating to ubuntu-server-netboot from ubuntu-server-netboot.py.

Expected behavior

grub.cfg is the same. No regression of grub.cfg.

Related Issue

https://github.com/dannf/ubuntu-server-netboot/issues/18

Additional context

After we land this pull request, I will build the python package and update the README to show how to install ubuntu-server-netboot as a python package from PyPI or as a deb package from PPA directly. We will address this issue in more details later.

tai271828 commented 3 years ago

Updated the pull request according to suggestion of code review. The pull request is ready to review again.