Breaking change (any change that would cause existing functionality to not work as expected)
Documentation Update
Description
Per our discussion on MM, we will poetry to manage ubuntu-server-netboot as a python package for the distribution purpose later, and development of test cases.
Checklist:
[ ] Add test cases to all the changes you introduce
[ ] Run poetry run pytest locally to ensure all linter checks pass
[ ] Update the documentation if necessary
Steps to Test This Pull Request
Follow the updated README and it should generate the same content of grub.cfg as what its previous codebase does. What the only change a user will be aware of is the command name migrating to ubuntu-server-netboot from ubuntu-server-netboot.py.
After we land this pull request, I will build the python package and update the README to show how to install ubuntu-server-netboot as a python package from PyPI or as a deb package from PPA directly. We will address this issue in more details later.
Types of changes
Description
Per our discussion on MM, we will
poetry
to manageubuntu-server-netboot
as a python package for the distribution purpose later, and development of test cases.Checklist:
poetry run pytest
locally to ensure all linter checks passSteps to Test This Pull Request
Follow the updated
README
and it should generate the same content ofgrub.cfg
as what its previous codebase does. What the only change a user will be aware of is the command name migrating toubuntu-server-netboot
fromubuntu-server-netboot.py
.Expected behavior
grub.cfg
is the same. No regression ofgrub.cfg
.Related Issue
https://github.com/dannf/ubuntu-server-netboot/issues/18
Additional context
After we land this pull request, I will build the python package and update the README to show how to install
ubuntu-server-netboot
as a python package from PyPI or as a deb package from PPA directly. We will address this issue in more details later.