danniehansen / activity-timer

Activity timer powerup for Trello
MIT License
44 stars 9 forks source link

Estimate accepts only entire hours #131

Closed Qterion closed 3 months ago

Qterion commented 6 months ago

Hey Dianne,

First of all, big thanks for the plugin! I've been using the PowerUp "Activity Timer," and it's been handy. But there's a hiccup in version 2.7.1 - can't input decimals right in the "Estimate" field. Like, when I try 0,5, it thinks it's 5 hours and 30 minutes.

Mind checking it out? Let me know if you need more info.

Thanks again! image-20231212-165443 image-20231212-165537

danniehansen commented 6 months ago

Hi @Qterion,

I'll check this out this weekend. Thank you for reporting it.

danniehansen commented 6 months ago

Hi @Qterion,

My apologies for not getting back earlier. The holidays is causing my time to be limited and haven't yet had the time that i was planning to look into this. I'll look into it as soon as possible.

Happy holidays :)

MoritzKrohn commented 5 months ago

I'd like to +1 this issue. Can't estimate anything but whole hours, either.

Otherwise this is a great power-up. Thanks for making it :) !

danniehansen commented 5 months ago

Sorry @MoritzKrohn & @Qterion for not getting back on this. Christmas and the past weeks has been tanking on my time.

I'll try to prioritize this as soon as possible to get it resolved 👍

MoritzKrohn commented 5 months ago

Ah, now worries & no hurry! I'm grateful that you've made this little tool and give it away for free. Thanks again for you efforts!

danniehansen commented 5 months ago

@MoritzKrohn & @Qterion

I've checked the current live version and decimals are working fine here. I think the problem may be that you're attempting to use , as a decimal indicator and not .

Works: 5.5 Doesn't work: 5,5

If you use . as a separator it should work just fine 👍

MoritzKrohn commented 5 months ago

@danniehansen No, I'm sorry, but that's not it. I tried a lot of things, including different decimal indicators, but also typing the estimate in another text editor and then copy pasting the value. Nothing worked so far!

I'd love to provide you a gif to illustrate the problem, but the "estimate" input-field doesn't even react to the typing of a period (.) so there's nothing to record. There's simply nothing happening.

Staying with your example of 5.5 hours:

a) If I type 5 followed by . followed by 5 again, the estimate shows 55h, because the . is not registered at all.

b) If I type 5 followed by , the comma shows, so we now have 5,. But as soon as I press 5 the second time to hopefully get to "5,5", the input field now weirdly shows 5.5,5. And as soon as I press Enter or click outside the input field, the estimate now is 555h. Only if I immediately click on "Save estimate" can I get 55:30h, but that's of little use unfortunately.

There's just no way to input a decimal, at least for me and Qterion, apparently. I'm not sure if this could have to do with me being on MacOS, but everything else related to Trello and Activity Timer works just fine.

Here's a gif showcasing the two examples, a) and b). You can't see what I'm typing, unfortunately, but the first time it is a period which is not showing, and the second time it's a comma which leads to a weird result.

estimate-problems

danniehansen commented 5 months ago

@MoritzKrohn Thank you for the detailed reply!

That is strange indeed. I'm suspecting it may be to localization differences with the field. I'll look into this 👍

Appreciate the detailed reporting 🙏

danniehansen commented 3 months ago

@MoritzKrohn @Qterion My apologies for the extended delay on getting this resolved. I was finally able to reproduce this in Firefox and traced it to locale configurations for the input field.

I've changed it to en-GB in https://github.com/danniehansen/activity-timer/releases/tag/2.7.5 and this appears to resolve the problem in Firefox and align both Safari, Firefox, Edge and Chrome.

Can you check to see if this resolves your problem? Please also if it persist confirm if you're running 2.7.5 in the board button 👍

MoritzKrohn commented 3 months ago

@danniehansen My apologies! I only today caught up on e-mails. Yes, amazing, it works now :)) ! Thanks a lot!!

danniehansen commented 3 months ago

No worries at all :) Glad it worked. Closing 👍