Closed krakenftw closed 1 month ago
also i am fairly new to open source, please point out the points of improvement. Here to learn : )
Hi @krakenftw thanks for your contribution.
At the moment, I can't accept this PR, there are too many linting changes in the stylesheet for me to review. In general, you should prevent any linters that don't result in git differences. If you would like to contribute a CSS linter setup, that would be in a separate PR.
Also, I think it makes sense to make the font size configurable for messages exclusively.
Your addition to the settings tab is still useful, and I can take over from here to revise this if you'd like.
Hey @danny-avila The linting changes were mess for me honestly, Prettier was doing the stuff and changed the whole thing. So basically that font-size would only affect the user/model messages?. I am ready to do this. Also an idea of which method i should opt to do this would be helpful. Since i am fairly new to open source.
Sorry for the long wait, applying my changes here: https://github.com/danny-avila/LibreChat/compare/feat/dynamic-font-size?expand=1
Introduced font-sizing in settings with all translations, Added a CSS var for font-size which changes according to the localstored font-size or default i.e 16px. #3207
Pull Request Template
⚠️ Before Submitting a PR, Please Review:
⚠️ Documentation Updates Notice:
Summary
Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.
Change Type
Please delete any irrelevant options.
Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
Checklist
Please delete any irrelevant options.