danny-avila / LibreChat

Enhanced ChatGPT Clone: Features Anthropic, AWS, OpenAI, Assistants API, Azure, Groq, o1, GPT-4o, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, langchain, DALL-E-3, ChatGPT Plugins, OpenAI Functions, Secure Multi-User System, Presets, completely open-source for self-hosting. Actively in public development.
https://librechat.ai/
MIT License
17.45k stars 2.9k forks source link

Enhancement: a11y for font size and localisation language in account settings #3770

Open danny-avila opened 3 weeks ago

danny-avila commented 3 weeks ago

Discussed in https://github.com/danny-avila/LibreChat/discussions/3769

Originally posted by **kukoboris** August 24, 2024 When I try to select font size and localisation language in the account settings, scrolling in the options selection menu doesn't work (neither mouse nor keyboard) изображение изображение
kukoboris commented 3 weeks ago

@danny-avila Selecting options does not work...

https://github.com/user-attachments/assets/72942a65-69a2-40fb-bb4d-76a3d2933134

danny-avila commented 3 weeks ago

https://github.com/user-attachments/assets/2b88003e-0758-4510-818e-52165f07bf63

it seems to work on my end, not sure what it could be at first glance

danny-avila commented 3 weeks ago

From the styling on your end, it could be an older version

kukoboris commented 3 weeks ago

@danny-avila I use image: ghcr.io/danny-avila/librechat-dev-api:latest. Made update 10 min ago

danny-avila commented 3 weeks ago

@danny-avila I use image: ghcr.io/danny-avila/librechat-dev-api:latest. Made update 10 min ago

Oh I see, there is something screwy there. I'm on it

danny-avila commented 3 weeks ago

@danny-avila I use image: ghcr.io/danny-avila/librechat-dev-api:latest. Made update 10 min ago

this might be unique to this build

danny-avila commented 3 weeks ago

@kukoboris the issue is fixed. in the librechat-dev-api build, the packages were resolving to a later version, likely of headlessui/react, which are unaccounted for.

I could have simply forced the package at the working version, but that would be a bandaid fix, and though the action I took may be disruptive, it's necessary to avoid bugs like this with other packages.

This is a long-standing issue with that particular image, I've decided to align that build closer to the main Dockerfile as it maintains package integrity, which prevents a host of npm issues leading to unaccounted dependencies.

Will watch out for this as well as write e2e tests for these simple dropdowns

kukoboris commented 3 weeks ago

@danny-avila Great! It works now! Thank you very much!