🫧 fix: Tool Auth Form Button to Prevent Form Bubbling - Githubissues

danny-avila / LibreChat

Enhanced ChatGPT Clone: Features Anthropic, AWS, OpenAI, Assistants API, Azure, Groq, o1, GPT-4o, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, langchain, DALL-E-3, ChatGPT Plugins, OpenAI Functions, Secure Multi-User System, Presets, completely open-source for self-hosting. Actively in public development.

https://librechat.ai/

MIT License

19.34k stars 3.23k forks source link

🫧 fix: Tool Auth Form Button to Prevent Form Bubbling #4666

Closed danny-avila closed 2 weeks ago

danny-avila commented 2 weeks ago

Summary

I modified the PluginAuthForm component to prevent form submission from bubbling up to the parent form by changing the submit button type and implementing manual submission handling.

Changed submit button type from "submit" to "button" to prevent automatic form submission
Added onClick handler to manually trigger form submission
Implemented direct form submission using handleSubmit with auth parameters
Maintained existing validation checks (isDirty, isValid, isSubmitting)
Preserved plugin installation parameters including pluginKey, action, and isEntityTool flags

Change Type

[x] Bug fix (non-breaking change which fixes an issue)

Testing

I tested the changes by:

Verifying the form submission works correctly with the new button type
Ensuring validation states are properly maintained
Confirming the form data is correctly passed to the parent component
Testing that no unwanted form submissions occur

Checklist

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] My changes do not introduce new warnings
[x] I have tested the functionality thoroughly