danny0838 / firefox-scrapbook

ScrapBook X – a legacy Firefox add-on that captures web pages to local device for future retrieval, organization, annotation, and edit.
Mozilla Public License 2.0
323 stars 65 forks source link

Add option to remove the status bar button #217

Open sergeevabc opened 7 years ago

sergeevabc commented 7 years ago

Dear Danny, Currently there are options to remove ScrapbookX from context menu, menubar and Tools. But there is no option to remove ScrapbookX from statusbar. Could you be so kind to add it?

danny0838 commented 7 years ago

Just like the toolbar one, the status bar icon can be customized by Firefox, and thus we do not add additional option for them to avoid a confusion. The status bar has been removed since Firefox 4.0. If you use an addon that add the statusbar, and the status bar icon cannot be customized, it is the addon that should implement it.

sergeevabc commented 7 years ago

Scrapbook’s statusbar icon is not movable in Pale Moon, whereas icons of other addons are.

mseliger commented 7 years ago

No problem to remove the icon from the statusbar with PaleMoon 27.3 on Windows 10 and Lubuntu. Perhaps your profile is broken. Try with a new profile and only the Scrapbook X extension.

sergeevabc commented 7 years ago

@mseliger, I forgot to mention the issue is related to development version, stable one works fine indeed.

danny0838 commented 7 years ago

@sergeevabc This is because the status bar button was totally removed in previous versions since it was basically replaced by the dropdown menu of toolbar button. The one in 1.14.* was added afterwards for those who still have status bar to work.

sergeevabc commented 7 years ago

Then let me repeat myself: statusbar icon is not movable now, whereas icons of other addons are. Either code that places icon in statusbar needs to be reworked or option to hide statusbar icon needs to be implemented. Not an urgent issue, but should be borne in mind for the future.

danny0838 commented 7 years ago

@sergeevabc You mentioned that the status bar icon of other addons are removable using the native Pale Moon customizer. Could you provide several examples?

sergeevabc commented 7 years ago

For example, let’s see how Textarea Cache add-on behaves (GIF screencast below).

danny0838 commented 7 years ago

@sergeevabc According to my test, there is only one button—which is probably the toolbar button rather than the status bar button—can be customized for Textarea Cache. Do you really see two customizable buttons?

sergeevabc commented 7 years ago

In regard to Textarea Cache, I see the only button which could be moved between different areas.

danny0838 commented 7 years ago

@sergeevabc The toolbar button can also be placed in the status bar via customization. We are not mentioning this when we talked about a status bar button—which is installed in the status bar by default and is no longer available in Firefox >= 4.0 without an addon.

sergeevabc commented 7 years ago

But in regard to ScrapbookX, there is a fixed icon (red) besides movable one (blue, which could be placed either in toolbar or statusbar). And the urge to get rid of the fixed one is the very reason we talk.

danny0838 commented 7 years ago

@sergeevabc You did not catch our point: Why the status bar button cannot be customized has two possible reasons: (1) ScrapBook X implemented it wrongly; (2) the Browser (Pale Moon) or the addon providing the status bar button functionality (e.g. status-4-ever) doesn't handle it in a correct way.

I think it's likely case (2) because ScrapBook X has implemented it in the way as same as before (Firefox < 4.0), and if I am right, this issue should be filed to the Pale Moon rather than to us.

sergeevabc commented 7 years ago

Not sure how statusbar is implemented in Pale Moon (@mattatobin did it), but it seems to be just another bar to place icons via customization. Nonetheless, would it be possible to make statusbar icon checkbox?

danny0838 commented 7 years ago

Is it technically possible? Yes.

Should we implement it? Probably not.

danny0838 commented 6 years ago

FYI: This is a test on Pale Moon 27.5 (x64), with ScrapBook X 1.14.4 and Quick Locale Switcher 1.7.8.51 installed. Both addons have a status bar button. When the customize dialog is open and the user begins to drag the status bar button out of the status bar, a popup shows up and the drag doesn't begin, and thus the user cannot drag it.

This should be an issue that Pale Moon needs to fix. You can report it to Pale Moon.

default

danny0838 commented 6 years ago

@mattatobin I don't get you. Aren't status bar buttons customizable just like toolbar buttons? If they are, it is the Pale Moon (or status4evar) that should provide the customization ability, not the addon developer to provide an option to hide them.

danny0838 commented 6 years ago

@mattatobin I know that a true status bar button is not a toolbar button, while I just think it should be as customizable as a toolbar button.

I just checked a Firefox 3.6 and failed to customize the status bar buttons—neither add/remove (show/hide) nor swap (move) them. Maybe there's something that I have missed? (Since it's not compatible with what you've said: "you could swap the order but not move them around".)

If (true) status bar buttons are really not customizable, it's reasonable that we add a toggle to show/hide them. Unfortunately, we haven't come up with a way to detect whether the status bar is supported by the browser or addon (it's not enough to detect whether Status-4-evar is installed, since there could be another addon that adds support for this feature), and the toggle option would be confusing for most users that simply don't have a status bar. Maybe someone can help us about the detection?

Additionally, I just found that there's an addon Organize Status Bar that allows moving and showing/hiding status bar buttons. It works on latest Pale Moon (27.5 (x64)), and anyone that would like this feature can use it before we come out a solution.

danny0838 commented 6 years ago

I cannot sort status bar buttons in normal mode—neither in Firefox 3.6 nor in Pale Moon. Could you provide some screenshots or a short video illustrating it?

Here are some addons that have a status bar button: Auto Pager, Quick Locale Switcher, and, of course, ScrapBook X.

Flashwalker commented 6 years ago

I can help you, danny! Checkbox labeled with just few words: "Hide icon from statusbar (if you have statusbar. If not - just ignore that)"