search

danny0838 / firefox-scrapbook

ScrapBook X – a legacy Firefox add-on that captures web pages to local device for future retrieval, organization, annotation, and edit.
Mozilla Public License 2.0
324 stars 65 forks source link

Full Text Searches open in tab regardless of setting in options #260

Closed Rising-Soul closed 4 years ago

Rising-Soul commented 6 years ago

In the Options, I've unticked 'Full text search' under 'Open in tab for the following operations', under Tabs. It still opens my searches in a new tab though, whether from the sidebar or from Manage.

I'm using Pale Moon 64bit 27.7.1, and Scrapbook X 1.14.5

Searches for Titles and other things work fine in the sidebar and Manage. Only full text doesn't work there.

danny0838 commented 6 years ago

By design full text search result is always opened in a tab—the current tab if 'Open in tab' is unchecked and a new tab if it's checked.

Rising-Soul commented 6 years ago

Oh! That wasn't very clear in the options. ;)

It'd be really nice if there was a way to display full text results in the sidebar like all the other search options.

And/or maybe a way to have the search results open in a new tab by default instead of the display pane below the results. I know I can right click to open them in a tab... but that seems to be the only way I can find.

danny0838 commented 4 years ago

Fulltext is implemented in a different module with the index search. We won't implement a change about this due to requirement of a large code work.