danny0838 / webscrapbook

A browser extension that captures web pages to local device or backend server for future retrieval, organization, annotation, and edit. This project inherits from legacy Firefox add-on ScrapBook X.
Mozilla Public License 2.0
908 stars 121 forks source link

"Capture tabs as" should have an option to show only folders amongst the dropdown list of "Target item" #360

Closed grotesque closed 1 year ago

grotesque commented 1 year ago

Hi Danny,

Excellent work with webscrapbook.

I think given that folders exists in webscrapbook they(folders) should be shown automatically in the dropdown. The "Select..." button can be used to select other types of items to capture the webpage under.

image

danny0838 commented 1 year ago

We probably won't do that.

Due to the server-client and async nature of WebScrapBook, a significant performance issue will be introduced to load all scrapbook trees when initiating a capture. Also, the HTML selector is linear and it's not easy to display hierarchical folders neatly.

grotesque commented 1 year ago

When we click select the response is fast suggesting the list is fetched locally and a python server network request isn't initiated. So it should be feasible to show only folders in the dropdown.

Regarding hierachical requirement we could just show 1st level of folders here.

danny0838 commented 1 year ago

I don't think showing only the first level folders is a desired and helpful behavior as there's no way to further expand them.

Considering the many potential issues that can be introduced by reading and/or syncing with the book tree(s) in the detail dialog directly, it obviously doesn't worth it.

Also note that the selector doesn't always mean the item for the captured item to be put under. It can also be the target item for a re-capture or merge capture. So there is also no rationale for it to be folder-only.

grotesque commented 1 year ago

When we click select we're already generating a server request. What I'm suggesting is have an option to only show folders as existence of folders mean they're more likely to be used to sort things by the webscrapbook users.

scrapbook-x had folder selection front and center.

image

image

image

@danny0838