Auto-close a tab after a capture

danny0838 / webscrapbook

A browser extension that captures web pages to local device or backend server for future retrieval, organization, annotation, and edit. This project inherits from legacy Firefox add-on ScrapBook X.

Mozilla Public License 2.0

908 stars 121 forks source link

Auto-close a tab after a capture #392

Open i3v opened 3 months ago

i3v commented 3 months ago

It would be great to have an easily-available "Capture tabs and auto-close" main menu item just below the normal "Capture tabs". Personally, I'd use both of them.

In this case, the "Options -> User interface -> Auto-close dialog on capture complete" could be re-purposed to control just the behavior of the new "Capture tabs and auto-close" menu button (personally, I'd like to use "If no warning, error, or failure").

danny0838 commented 3 months ago

We don't tend to do this as there would be lots of "capture tabs and auto close", "apture bookmark and auto close", etc. if we propagate that, let alone possibly different values for auto close.

I think that the auto close behavior is a rather universal personal preference and not likely changed. Is there a rationale that auto-close and non-auto-close be both frequently used?

i3v commented 3 months ago

Well, I do understand your concern... My rationale for me is very simple:

Sometimes I'm still reading a page when I decide that I want to capture it. I definitely don't want it to get closed suddenly. Neither I want to keep in mind that I have to capture it later.
Sometimes I'm already done reading and then I decide to capture it. I don't really want to wait for the capturing process to finish, neither I want to thing about this page again in the next few minutes.

danny0838 commented 3 months ago

Well, this feature does not afftct the page tab at all. It closes only the capture dialog window.

i3v commented 3 months ago

Ha, I was a bit wrong about that option then. For the scenario I mentioned, it would be nice, if the tab(s) would get auto-closed (if there would be no errors).

danny0838 commented 3 months ago

It will be a feature request, then.

We generally don't tend to do this since closing a tab after a capture is beyond the core functionality. You can also do something like grouping the pages to be captured in another window and close them all together afterwards.