Port some things to the latest 1.* of jQuery/UI

dannybd / courseroad

CourseRoad is a four-year academic planner for undergraduates.

Other

62 stars 15 forks source link

Port some things to the latest 1.* of jQuery/UI #14

Closed betaveros closed 7 years ago

betaveros commented 7 years ago

for tabs, change 'selected' to 'active'
parseJSON('') throws an error instead of giving null, so just make it parse the 0 that seems to be what we want
give the drag-class drop handler some parameters its missing, and get the dragged html in a more reliable way. This also makes it work in Firefox

dannybd commented 7 years ago

Oh, excellent! I've been afraid to do this for a while.

Two bugs I'm seeing with this port:

1) When you log in, the ui-tabs-active class is still set on the About tab. I believe in the older version of jQuery UI, it just removed it, but this will need to selectively add that class based on whether you're logged in. (I was doing that without JS so there's not a content flash on JS load.)

screen shot 2016-08-19 at 10 08 48 am

2) The dialogs seem to be all broken: User Settings, View Saved Roads, and Help. Each isn't loading as a modal, so I'm guessing something got renamed. Mind taking a look at that too?

screen shot 2016-08-19 at 10 04 30 am

Thanks so much for helping out with this!

betaveros commented 7 years ago

Cool, so:

I set the starting tab styles through PHP.
The modal overlay seems to depend on CSS that jQuery previously directly set on the element with JS, but now expects to be taken care of by some CSS theme it ships with, so I added the relevant rules.
For the modal itself, 1.11 changed the z-index algorithm in some unclear way; that's all I could find on the matter and it's not really clear what jQuery's recommended way to deal with this is (not use z-index at all?), but giving the dialog class a z-index through our CSS works.

betaveros commented 7 years ago

Ping? Anything else you need?

dannybd commented 7 years ago

I'm currently on vacation; I'll be able to test and accept this new week. Sorry about that.

On Thursday, August 25, 2016, Brian Chen notifications@github.com wrote:

Ping? Anything else you need?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dannybd/courseroad/pull/14#issuecomment-242285440, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWFzT-fcTpWJ9cCQSz1HnlDEmCU0Hqjks5qjSnlgaJpZM4Jntga .

Danny Ben-David

dannybd commented 7 years ago

Yep, looks great! Thanks so much!