search

dannybd / courseroad

CourseRoad is a four-year academic planner for undergraduates.
Other
62 stars 15 forks source link

unbreak m18_pure #32

Closed npfoss closed 5 years ago

dannybd commented 5 years ago

Can you explain? Pushing this will immediately break everyone who has m18_theoretical in a saved road.

If you really need it, maybe define something like majors.m18_pure = majors.’18_theoretical?

npfoss commented 5 years ago

ohhh sorry sorry. I thought the breaking change went through in the other PR and needed to be undone! never mind

dannybd commented 5 years ago

Nope! I tweaked it locally before pushing. You’re fine :)

On Fri, Sep 14, 2018 at 8:54 AM Nate notifications@github.com wrote:

Closed #32 https://github.com/dannybd/courseroad/pull/32.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/dannybd/courseroad/pull/32#event-1846462882, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWFzTiNEXzTC54_0IQNs2KX5vZ4zw9rks5ua9EdgaJpZM4WphKd .