search

dannydjdk / Nutritional-Balance

A Minecraft mod that enhances the food system to encourage you to eat a balanced diet.
https://www.curseforge.com/minecraft/mc-mods/nutritional-balance
GNU General Public License v3.0
3 stars 6 forks source link

Incompatible with Candlelight Dinner Mod multi-use meals #31

Open KaliKallixti opened 1 year ago

KaliKallixti commented 1 year ago

Eating the Lasagna meal from Candlelight Dinner - has four portions in one bowl - caused a ticking exception in Neruina

image

dannydjdk commented 1 year ago

Thanks for the report! Do you have a crash report and/or a link to the other mods contributing to the crash? Also, what is the reason you believe Nutritional Balance is the reason for this crash? I am unable to troubleshoot this without more information or some way to reproduce the problem.

KaliKallixti commented 1 year ago

Hi! I'm so sorry, I accidentally left out the crucial bit- eating the Lasagna meal from Candlelight Dinner specifically from the Nutritional Balance lunchbox causes the kick due to a ticking exception. I only assume it's because it's a multi-use meal, but it's definitely every time on my end. I don't have a crash report because it's not crashing me, it's just kicking me from the server (in this case the Cottage Witch Recast modpack public server.)

dannydjdk commented 1 year ago

Got it! I was able to reproduce the crash, so I can begin troubleshooting. I was a bit confused, because the mod is actually called [Let's Do] Candlelight, and I could find a mod called Candlelight Dinner.

dannydjdk commented 1 year ago

Unfortunately, this is not something that can be fixed on my end, and this will likely break with any lunchbox from any mod.

The problem is that Candlelight is attempting to access the inventory slot directly within the user's inventory: https://github.com/satisfyu/Candlelight-Dinner/blob/2c53ea65b934d393875c1b9e5a6d56edc74f0b34/common/src/main/java/satisfyu/candlelight/food/EffectFoodBlockItem.java#L57C44-L57C44

That function returns -1, because, of course, the item is not in a player's inventory slot. So this line then causes the crash: https://github.com/satisfyu/Candlelight-Dinner/blob/2c53ea65b934d393875c1b9e5a6d56edc74f0b34/common/src/main/java/satisfyu/candlelight/food/EffectFoodBlockItem.java#L63

Unfortunately, they don't have an issue tracker on GitHub, so I can't link this issue to an issue there. You have to go to their Discord to report it.