search

dannyedel / dspdfviewer

Dual-Screen PDF Viewer for latex-beamer
http://dspdfviewer.danny-edel.de
GNU General Public License v2.0
219 stars 29 forks source link

German translation #84

Closed projekter closed 9 years ago

projekter commented 9 years ago

Finished German translation. I suggest not to translate the application name. Any translation would sound weird and will only cause confusion - when talking about a certain product, it should be called the same in all languages.

dannyedel commented 9 years ago

Is it possible to box the "set name to libdspdfviewer" part into some "If on Windows" statement? On unix, this results in generating a liblibdspdfviewer filename, which looks weird (and which was the reason why I added the set name statement in the first place)

If you have a better Idea (maybe, how to supress the automatic lib prefix on Unix, and simply setting the name to libdspdfviewer on all plaforms), that would of course be even better.

Other than that, great PR :thumbsup:

projekter commented 9 years ago

Ok, I added a simple switch which checks for MSVC. I don't know how other compilers on Windows will behave.

dannyedel commented 9 years ago

Thanks, looks good to me!

If it's an issue on other compilers then we handle when it actually causes a problem for someone.