search

dannyedel / dspdfviewer

Dual-Screen PDF Viewer for latex-beamer
http://dspdfviewer.danny-edel.de
GNU General Public License v2.0
219 stars 29 forks source link

Display window on startup #88

Closed projekter closed 8 years ago

projekter commented 8 years ago

Fix of last pull request #84 (detection of MSVC - there seems to be a difference between CMAKE_CXX_COMPILER_ID and "${CMAKE_CXX_COMPILER_ID}"). Fixed #87.

dannyedel commented 8 years ago

Travis failed to build on all currently supported platforms. While the Linux/Qt5 platforms timed out waiting for confirmation (they didn't do this last month, I swear! Should be fixed in 4f34113), the Qt4 platforms failed to build since they don't have QWindow.

Please enclose the Qt5-specific code in #if qt5 / #else (you may depend on the POPPLER_QT5 definition) and also please git rebase the pull request onto my current master branch. (You can force-push pull requests, github handles that nicely)

projekter commented 8 years ago

Ok, introduced the conditionals and rebased.