search

dannyklaassen / expo-unlimited-secure-store

MIT License
27 stars 25 forks source link

README needs a little updating. #1

Open Asday opened 5 years ago

Asday commented 5 years ago

The 2KiB limit has (kinda) always been present. A user noticed data loss issues when storing a lot in securestore, (about 80KiB), and raised an issue with Expo, who added the warning in SDK33.

Also, though I'm less sure of this, if this library is untranspiled, the README should have instructions as to how to exclude it from the transformIgnorePatterns for jest integration, as detailed here.

istvan-szilagyi commented 5 years ago

Actually I don't know since when, but they only mentioned in their documentation on SDK 33 release.

I will update the README, and will also create unit tests, but for now I just added this to have some info how to use it. I only finished the package yesterday :)

Asday commented 5 years ago

https://github.com/expo/expo/issues/2556 For reference.

istvan-szilagyi commented 5 years ago

Ok I see, but as I can understand limitations were coming from Android

"Android's crypto implementations do differ across versions of Android and devices"

So if data was larger than 2KB it may have failed (data was not saved) and except that nothing really happened, but in next SDK SecureStore will check the size and it will throw an error if data is larger, right?

Asday commented 5 years ago

I'm honestly not sure where they got the 2KiB number from, you know. They tested on one device, and then halved it, I guess?

But yeah, >2KiB will throw an error in future, "just because", to save silent errors and data loss.

istvan-szilagyi commented 5 years ago

Ok so basically I just have to change that it will be a limitation from next SDK.

Thanks :)