search

dannyneil / pytorch_plstm

MIT License
21 stars 3 forks source link

Is masking implemented? #2

Closed kevinpeterson closed 3 years ago

kevinpeterson commented 3 years ago

Is masking actually being used? I see it referenced here:

https://github.com/dannyneil/pytorch_plstm/blob/96cc3b6f02d298cac433e1c479fb03ba41b824df/main.py#L105

but does it actually get used or have any impact?

dannyneil commented 3 years ago

Thanks for asking. No, it was used in the original code but I did not reimplement here.