danobot / entity-controller

Home Assistant Entity and lighting controller for managing devices with timers, scripts, and sun-based time restrictions.
https://danobot.github.io/ec-docs/
GNU General Public License v3.0
289 stars 41 forks source link

feat: warn about mismatched timezones #311 #312

Closed Tabisch closed 4 months ago

Tabisch commented 8 months ago

Description

With this pull request i want to introduce a error message, if the home assistant and system timezones are mismatched. This may cause the start_time_callback function to get called repeatedly.

With this change the user should become aware, that their current configuration might be an issue.

Checklist

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

License

By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license. Thank you for contributing!

Related Issues

311

Closes

danobot commented 6 months ago

Hi @Tabisch , this looks good. Please remove any version bumps and edits to md or json files (they are automatic). Once done I will merge

danobot commented 5 months ago

Hi @Tabisch , if you can remove the changes requested above I'm happy to merge this to develop and test

Tabisch commented 5 months ago

@danobot Really sorry that I didn’t awnser you. Have been busy with Uni and am currently on a trip. I will do that next week. I’m back home on the 20th so I will try to get that done til the sunday after that.

Tabisch commented 5 months ago

Did a rebase to develop. I hope this gets rid of the bumps and edits that you mentioned. The compare thing tells me that only the init.py is now changed compared to that branch.

Sorry im not that familiar with git so I dont know if that's how this works.