danobot / entity-controller

Home Assistant Entity and lighting controller for managing devices with timers, scripts, and sun-based time restrictions.
https://danobot.github.io/ec-docs/
GNU General Public License v3.0
289 stars 41 forks source link

Replace async_track_state_change with async_track_state_change_event #327

Closed mikeage closed 2 months ago

mikeage commented 2 months ago

Throws warnings in 2024.5+

See https://developers.home-assistant.io/blog/2024/04/13/deprecate_async_track_state_change/

Note that the component still doesn't work properly under 2024.5; see #326 .

Description

Checklist

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

License

By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license. Thank you for contributing!

Related Issues

Closes

robchandhok commented 2 months ago

This patch works for me.

elupus commented 2 months ago

Looks good to me. The threading fixes in that other issue are needed to get it up and running again.