search

danocmx / node-tf2-item-format

Fully typed battle-tested library that helps you format TF2 items to the community standards.
MIT License
24 stars 4 forks source link

Inproper defindexes in `parseString` #176

Open arik123 opened 2 years ago

arik123 commented 2 years ago

Non-Craftable Killstreak Eyelander Kit defindex returned: 5726 expected: 6527 Genuine Marxman defindex returned: 816 expected: 837 Any warpaint - you return 9536 - which is generic warpaint, instead of returning the specific warpaint defindex Cool Candy Coated War Paint (Battle Scarred) defindex returned: 9536 expected: 17258

This is just a diference between your library and autobot library, I'm not 100% sure problem is in your library Hot Blitzkrieg SMG (Battle Scarred) defindex returned: 203 expected: 15153

danocmx commented 2 years ago

Hey, these issues are related to schema implementation. That's why you can implement it on your own to fix these issues, tf2-item-format/static part is not meant for production applications, but rather for quick conversion between different formats in small applications. I've know autobot has large sets of hard coded definition indices and I'm conflicted whether or not I should try to add those to the static part. You are of course free to make a pull request.

This issue is related to the parseString function which can only obtain limited data from just item name. For parseEconItem there is an extra option useTrueDefindex to get the data from tf2 wiki link.