Optimize isNumber util func

[piman51277]

Summary

Optimize the isNumber function for a general performance improvement.

Rationale

Why this works:

• Any sensical value that would pass str === 'number' would also pass !isNaN(str), as all non-NaN numbers are typeof 'number'.
  • Granted, this assumes that str cannot be NaN, but in the contexts where this function is used, it cannot be NaN.
• The regex /^\d+$/ matches any string that contains only digits. This is checking whether the string itself is numeric, something isNaN accomplishes.
  • See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN

Why do we need this?

• This provides a performance boost to this function
• This function is called many times in normal use, making it a good target for optimization

Benchmarks

Ran on i7-1360P on Debian 12.0 Benchmark performed using benchmark library

parseEconItem

original x 15,778 ops/sec ±0.60% (96 runs sampled)
optimized x 18,380 ops/sec ±0.53% (94 runs sampled)
Fastest is optimized

In repeated tests, this has shown a 10-15% speedup in execution time

[danocmx]

Can you replace the PR specific comment with a shortened version and cast the string to number instead of @ts-expect-error?

[piman51277]

I have done that.

[github-actions[bot]]

:tada: This PR is included in version 5.9.1 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: