search

danomagnum / gologix

Ethernet/IP client library for Go inspired by pylogix that aims to be easy to use. Supports being a client and a class 3 / class 1 server.
MIT License
32 stars 8 forks source link

Multiple modifications for formatting and function #21

Closed treavorj closed 1 week ago

treavorj commented 2 weeks ago

Here is a partial functional update for the code modifications that I am working on to better use the library for me. So far, all the functional code updates are for the client. You will see some modifications for the server, but they were nonfunctional spelling/grammar updates. If you do/do not like the direction that this code is going, feel free to let me know and I can try to mesh our visions. In case I did not make it clear in my issue, great job with the code already! This is just my attempt to add what I view as some polish.

Key updates include:

Testing: All automated tests pass. I have confirmed a large portion (hopefully all) of the functionality that I touched on an AB CompactLogix with no noticed issues.

danomagnum commented 2 weeks ago

Thanks for all the updates. I've started reviewing it and like what I see so far.

It would appear I'm having trouble with the reconnection and noreconnection tests. Might just be a timeout thing, I'll look at it further over the next few days as I get a chance.

Also, I really need to start using a spell checker - I had so many typos.

treavorj commented 2 weeks ago

Haha all good. I get just focusing on the content as that is what is more important at the end of the day. Let me know if you're still having issues with the connection tests and I can take a look at it early next week (unfortunately off on other things for the exact moment).

danomagnum commented 1 week ago

I found the problem with the reconnect test.

See this comment: https://github.com/danomagnum/gologix/pull/21#discussion_r1650271037

treavorj commented 1 week ago

@danomagnum Everything should now be up to date and ready for additional review.