search

danomatic / react-pdf-html

Render HTML in react-pdf
MIT License
162 stars 39 forks source link

  entity is not preventing line break #36

Open girlboss-energy opened 2 years ago

girlboss-energy commented 2 years ago

Version: 1.1.8

&nbsp entity seems to be correctly replaced by space but the non breaking functionality is not working. Here is my test code:

          <Document style={{ fontFamily: 'Roboto' }}>
            <Page style={{ padding: 15 }}>
              <Html style={{ fontSize: 13 }}>
                {`tets text: Lorem ipsum dolor sit amet,
                consectetur adipiscing elit. Cras eget ultricies lacus. Quisque
                dignissim purus nibh, ac efficitur justo aliquet id. Quisque
                magna magna, placerat non venenatis vel, volutpat ac libero.
                Etiam sit amet diam facilisis, posuere enim nec, eleifend ex ex.
                Phasellus&nbsp;NOBREAK scelerisque, sapien quis ullamcorper tincidunt,
                elit metus maximus augue, eu luctus nunc sem a nisl. Vestibulum
                bibendum ornare mauris sed accumsan. Phasellus&nbsp;NOBREAK non
                finibus est. Vivamus aliquet nulla et orci euismod, non molestie
                felis semper. Aenean lacinia tellus sem, quis tincidunt leo
                pharetra non. Cras consequat nulla et tellus porttitor dictum.
                Fusce leo elit, ultrices eget volutpat nec, fermentum ut mi.
                Aliquam ultricies euismod tortor, et rhoncus diam maximus in.
                Cras convallis hendrerit feugiat. Vestibulum a euismod est, sed
                dignissim ipsum. Etiam maximus nisi risus, sit amet commodo
                libero viverra a. Suspendisse mattis tellus vitae leo viverra
                egestas.`}
              </Html>
            </Page>
          </Document>

and here's how it renders:

image

danomatic commented 2 years ago

@MagicalPrincess I don't think &nbsp; prevents text wrapping. It just prevents the browser from collapsing multiple spaces into a single space

danomatic commented 2 years ago

@MagicalPrincess my mistake. I didn't realize that it was supposed to prevent line breaks as well. In all my years doing web dev I've never used it for that!

danomatic commented 2 years ago

That being said. I'm not sure if there's a way with react-pdf to achieve this, but I'll think about it