danomatika / ofxLua

(maintained) a lua scripting interface & bindings for openFrameworks
Other
164 stars 36 forks source link

Conversion problem file lstrlib.c #35

Closed felipetesc closed 7 years ago

felipetesc commented 7 years ago

I found another small issue, on line number 936 of the file "stdlib.c", it's located inside the "Lua" folder. It belongs to Lua source itself, I've looked at the file's header, and the author's name is Roberto and it was created at 05/20/2016. Searching the internet, I've found this: http://lua-users.org/lists/lua-l/2016-06/msg00387.html

The issue itself it's just a conversion problem inside the method witch signature is "static void checkdp (char *buff, int nb)", it's a C++ problem, I don't know if GNU G++, or a non VS C++ compiler will have the same problem. I will investigate more, but no guarantees to find something.

felipetesc commented 7 years ago

I followed this: http://lua-users.org/lists/lua-l/2016-06/msg00387.html and it worked. In line 283 of the lobject.c of: char * pdot = (char *) strchr (s, '.'); char pdot = strchr (s, '.'); ` And in the line 936 of lstrlib.c I changed fromchar ppoint = memchr (buff, dot, nb);tochar ppoint = (char ) (memchr (buff, dot, nb)); I encountered another problem when I building the project: I am going to open a new topic, before that, I'll anticipate with info: it happened when linking Lua.

danomatika commented 7 years ago

Looks like this was fixed in lua 5.3.4. Can you pull the latest commit and try building again?