Emscripten update (temporary fix) / update of Pure Data submodule

danomatika / ofxPd

(maintained) a Pure Data addon for OpenFrameworks using libpd

Other

202 stars 45 forks source link

Emscripten update (temporary fix) / update of Pure Data submodule #99

Closed Jonathhhan closed 5 months ago

Jonathhhan commented 5 months ago

A temporary fix for Emscripten. More a suggestion than a PR. https://github.com/danomatika/ofxPd/blob/master/scripts/update_libpd.sh git clone -b emscripten --recurse-submodules --remote-submodules https://github.com/Jonathhhan/libpd.git When this PR https://github.com/pure-data/pure-data/pull/2244 is merged, the Pure Data submodule can be replaced with the current master instead of my branch. Most of the changes are from updating the submodule.

umlaeute commented 5 months ago

i've just rejected https://github.com/pure-data/pure-data/pull/2244 on the grounds that (i think) it is breaking stuff on unrelated platforms (Max/MSP).

the proper fix for the underlying build problem is to fix the build system to not compile binarymsg.c (no idea whether this is a problem of libpd or ofxPd or your personal project)

Jonathhhan commented 5 months ago

@umlaeute I made a mistake and the PR is not needed. Emscripten works with libpd, if the Pure Data submodule is the current master branch (not sure how to make a PR for that).