search

danomatika / swig-openframeworks

a SWIG interface for openFrameworks with included Makefile, submodule this in your language wrapper addons
Other
39 stars 11 forks source link

Changes to allow ofxLua to work on latest OF #13

Closed johnkingsley closed 7 years ago

johnkingsley commented 7 years ago

I'm not sure if you want these changes, but I thought I'd send them in case you do want them -- it might save you some work.

These changes are the result of trying to get ofxLua working on the latest github version of OF.

Many of the changes are related to the change in OF paths. (std::filesystem::path is now used instead of std::string)

I can break these changes into smaller pull requests, if you prefer.

danomatika commented 7 years ago

As the readme states, the ofxLua master branch is kept up to date with the latest OF release and not current development work. We can wait for the next OF release or possible create a develop branch to incorporate this PR.

This is mainly because the API can change as development happens and it's simply easier for me to wait until things are finalized in a release.

danomatika commented 7 years ago

Also, I will see if there is a way to use a typemap swig can treat all std::filesystem::path types as std::string. As you've found, having to write manual wrappers to handle this is a pain.

johnkingsley commented 7 years ago

Yes, it makes sense to wait for the next official release. I only made the pull request to maybe save someone the hassle of re-doing my work. Unfortunately, the OF releases don't happen very often. :-(

It also makes sense to set up a typemap for std::filesystem::path <-> string conversion. I thought about it, but my swig knowledge is very limited.

danomatika commented 7 years ago

I've incorporated your changes in the latest commits but it looks like there are quite a lot more extends to add. I messed around with a type map but didn't have too much luck, will need to try again.

Test and let me know if the current master builds for you with OF 0.10.0.

johnkingsley commented 7 years ago

Super! Thanks for the changes.

I tested it on the latest version of OF and created pull request #14 to fix some minor typos.