search

danpalmer / jquery.complexify.js

Complexify helps you to accurately gauge the quality of a user's password to give them visual feedback, and to enforce a minimum level of security.
http://danpalmer.me/jquery-complexify
653 stars 189 forks source link

Include Banlist in minified script #15

Closed nickshanks closed 9 years ago

nickshanks commented 11 years ago

The point of minifying your script is to reduce bandwidth. Splitting the banlist out into a separate file means two serialised HTTP requests, the banlist needing to complete before the main complexify script can be executed. They should be combined into one file when minified (leave as two if you like for debug builds, though even there I don't see the benefit).

danpalmer commented 11 years ago

Yeah, I did consider this. To be honest I ever use the compressed version because I think it's the responsibility of the production environment to compress and minify, code should always be kept in the readable 'canonical' form. However I received a request for a minified version so that's why it exists. I'll sort this when I next push some changes.

nickshanks commented 11 years ago

i guess it depends on the size of the website and the developer's experience. for someone running a photo blog who's never seen a line of C code or written a shell script in their lives it's probably quite daunting to design and write a production pipeline, and possibly quite unnecessary. When you are one of ten thousand programmers at the Googleplex, it's something you do before getting your breakfast :-)

On 23 April 2013 18:08, Dan Palmer notifications@github.com wrote:

Yeah, I did consider this. To be honest I ever use the compressed version because I think it's the responsibility of the production environment to compress and minify, code should always be kept in the readable 'canonical' form. However I received a request for a minified version so that's why it exists. I'll sort this when I next push some changes.

— Reply to this email directly or view it on GitHubhttps://github.com/danpalmer/jquery.complexify.js/issues/15#issuecomment-16872045 .

Nicholas.

NicolasCARPi commented 10 years ago

Yeah, put everything in one file ! :)