search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 734 forks source link

Issue Transferring Funds to coinbase from gdax #176

Open rpringst opened 6 years ago

rpringst commented 6 years ago

Wonderful library you have here, but I did find one glitch (And am not github savvy enough to upload the fix myself). When using the function coinbase_withdraw as part of the authenticated_client class, you always get a 'route not found' error. At line 254 of this file, it reads:

r = requests.post(self.url + "/withdrawals/coinbase", data=json.dumps(payload), auth=self.auth, timeout=30)

But the correct url, as per my scouring of the GDAX API, is actually found at "/withdrawals/coinbase-account". Thanks in advance, brev!

derenma commented 6 years ago

Is it possible that you are confusing 'withdraw' with 'coinbase_withdraw' or 'crypto_withdraw'? Submitting a PR that may fix.

rpringst commented 6 years ago

No, the issue is that the rest api url for that method is incorrect. Compare and contrast each pair of methods, and you'll see that. I already fixed it on the library installed on my system, works perfectly, I just don't 'github' much...

On Dec 11, 2017 1:34 AM, "endian0A" notifications@github.com wrote:

Is it possible that you are confusing 'withdraw' with 'coinbase_withdraw' or 'crypto_withdraw'? Submitting a PR that may fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danpaquin/gdax-python/issues/176#issuecomment-350643751, or mute the thread https://github.com/notifications/unsubscribe-auth/ATH7EkPUvp5WS7FAipZT7rIGY16YjJgXks5s_NsggaJpZM4Q8b7H .

danpaquin commented 6 years ago

This remains an issue that needs to be updated ASAP in addition to supporting all payment-types.

If this issue isn't closed, anyone capable of submitting a PR for this would be appreciated.