search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 732 forks source link

"product_id" not working on a few methods #286

Closed itaki closed 6 years ago

itaki commented 6 years ago

"product_id" doesn't seem to be working on either the get_orders() or the cancel_all() methods. With get_orders, I can use the method, but not with a product_id. If I put a product_id in I get an error

get_orders() got an unexpected keyword argument 'product_id'

However, with the cancel_all method, even leaving it blank I get this error "data=json.dumps({'product_id': product or self.product_id}), auth=self.auth) AttributeError: 'AuthenticatedClient' object has no attribute 'product_id''

itaki commented 6 years ago

Digging through the other issues I see the cancel_all problem may be related to the issue pointed out by bradowatson a couple weeks ago where product="BTC-USD" but not product_id="BTC-ETH"

mcardillo55 commented 6 years ago

Dupe of #274. Closing.

itaki commented 6 years ago

Really don't think this is a direct duplicate of #274. If anything this information extends the issues in #274. Nonetheless, I have added this info to it anyway.