search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 737 forks source link

Encode auth signiture as string in JSON payload #294

Closed gsmadi closed 5 years ago

gsmadi commented 6 years ago

Fixes an issue with Python 3 where encoding the base64 signature bytes in the auth JSON payload would fail with a TypeError.

Here is the error that is addressed in this pull request: TypeError: Object of type 'bytes' is not JSON serializable

alimcmaster1 commented 5 years ago

Makes sense to me! Do we have any unit test coverage of this?

danpaquin commented 5 years ago

This code was provided by Coinbase themselves. Could we, instead, make an exception for Python3 and detail the script that requires this change to be made?

Thanks for the contribution!