Closed kenfehling closed 6 years ago
see line122 of public_client.py
def get_product_trades(self, product_id, before='', after='', limit='', result=[]):`
limit is defaulted to empty string, while when checking lines 128-129
limit (Optional[int]): the desired number of trades (can be more than 100,
automatically paginated)
and 154-156
if limit and limit < 100:
# the default limit is 100
# we only add it if the limit is less than 100
it should be limit=100
(line 122)
Fixed locally and works, sorry have no experience with github to fix it here.
When I try to use these parameters as specified (passing in date strings) I get a response:
However if I use integer ID numbers it works: https://api.gdax.com/products/BTC-USD/trades?after=2
Am I maybe doing something wrong or are these not actually supposed to work with dates, only ID numbers?