search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 737 forks source link

bintrees is deprecated, suggests sortedcontainers #297

Closed grantjenks closed 5 years ago

grantjenks commented 6 years ago

Hi, I'm the author of sortedcontainers and noticed that you're using the bintrees module. If you look at the PyPI page for bintrees then you'll see that development has stopped and sortedcontainers is recommended instead.

I'd love to see sortedcontainers used in more places. If I created a pull request which replaced bintrees with sortedcontainers, would that be merged?

alimcmaster1 commented 6 years ago

Hey Grant,

Ive used sortedcontainers a little before so I’m happy to submit a PR. Would be a good opportunity for me to understand sorted containers better. You okay with this?

Would be great if you could review our implementation too. @danpaquin any concerns on this ?

alimcmaster1 commented 6 years ago

Actually i noticed this has already been done and merged to master. https://github.com/danpaquin/gdax-python/pull/272/commits

Whenever the latest version is released to PyPI this will be fixed.

Thanks,

grantjenks commented 6 years ago

Those changes look good but I think they missed one spot in setup.py: https://github.com/danpaquin/gdax-python/blob/master/setup.py#L6