search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 737 forks source link

Development #301

Closed brokencog closed 5 years ago

brokencog commented 6 years ago

get_product_trades() was incorrectly setting default value of limit argument to string '', rather than int 0.

alimcmaster1 commented 6 years ago

Hi what are you attempting to do here/ what's the issue?

brokencog commented 6 years ago

Sorry for the slow response.

The issue seemed fairly simple -- the function get_product_trades() has several arguements, one of which is "limit". This arg was being assigned a default value of '' ... that is: limit='' ... this is causing a problem in the function when limit is used as an integer. I was attempting to change the function definition to "limit=0" ... however I suck at git (and don't really care to unsuck) and as a result don't know what has been pushed or pulled for review.

alimcmaster1 commented 5 years ago

Ive fixed this in #311

brokencog commented 5 years ago

Great.

-daniel

On Mon, Aug 6, 2018 at 4:33 PM alimcmaster1 notifications@github.com wrote:

Ive fixed this in #311 https://github.com/danpaquin/gdax-python/pull/311

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danpaquin/gdax-python/pull/301#issuecomment-410885280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwqLNYw_jcisv1sWtSjZPPoHWOfmOiNks5uONIxgaJpZM4Uh41y .

danpaquin commented 5 years ago

This is fantastic. I merged the changes. Thank you all for your contribution on this.