search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 737 forks source link

Continuous Integration Set up #312

Closed alimcmaster1 closed 5 years ago

alimcmaster1 commented 5 years ago

What are peoples thoughts on setting up tests to run on travis and have some form of CI? Im happy to add the config yaml file.

danpaquin commented 5 years ago

I'd be happy to review a PR regarding this.

uclatommy commented 5 years ago

Yes please! I have been using this project for a few months and it has been a blessing to be able to have it, but it seems like some functionality occasionally regresses on new releases due to inadequate unit tests and CI.

carlomazzaferro commented 5 years ago

Would travis be ok @danpaquin ? I can work on a prototype as I've been working a bit with it for other projects.

alimcmaster1 commented 5 years ago

Thanks @carlomazzaferro , ive already submitted a PR for this as there isn't much to it. Setting up something simple for now

danpaquin commented 5 years ago

This has been implemented via #318 , but not ironed out. Please feel free to submit a PR for any improvements!