search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 732 forks source link

cancel_after not working #317

Closed AlexFine closed 6 years ago

AlexFine commented 6 years ago

I'm running: auth_client.buy(price = str(price), #USD order_type='limit', size = str(volume), #BTC product_id = currency + '-USD', tif = 'GTT', cancel_after = 'min', post_only = 'true') and the trade is put on the order books, however, the cancel_after is not working. It never cancels. I've also tried the same thing with cancel_after = '1' and it didn't work either.

I presume I'm doing something wrong. Can anyone spot it?

Any help is appreciated!

danpaquin commented 6 years ago

After taking a second look, this could be related to an exchange issue, since all request parameters are sent together. In my adhoc test, if any data reaches the exchange servers, all data hits the server.

Lastly, are you using the current repository? If not, what version are you running?

danpaquin commented 6 years ago

Great find! Merged and will close this out after pip is updated.

alimcmaster1 commented 6 years ago

Thanks Chris,

We have recently just introduced CI on travis and that was the first build that ran. I’ll fix this today.

Thanks,

Alistair

Sent from my iPhone

On 27 Aug 2018, at 15:07, Daniel Paquin notifications@github.com wrote:

Great find! Merged and will close this out after pip is updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

AlexFine commented 6 years ago

@chrisjbroeren that works perfectly, thanks!!

danpaquin commented 6 years ago

this has been resolved in pip version 1.1.3