search

danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 737 forks source link

WebSocket authentication bug - incorrect mapping of "auth_headers" values to "sub_params" values #319

Closed jaredtkatz closed 5 years ago

jaredtkatz commented 5 years ago

current mappings:

            sub_params['signature'] = auth_headers['CB-ACCESS-SIGN']
            sub_params['key'] = auth_headers['CB-ACCESS-SIGN']
            sub_params['passphrase'] = auth_headers['CB-ACCESS-KEY']
            sub_params['timestamp'] = auth_headers['CB-ACCESS-TIMESTAMP']

correct mappings:

            sub_params['signature'] = auth_headers['CB-ACCESS-SIGN']
            sub_params['key'] = auth_headers['CB-ACCESS-KEY']
            sub_params['passphrase'] = auth_headers['CB-ACCESS-PASSPHRASE']
            sub_params['timestamp'] = auth_headers['CB-ACCESS-TIMESTAMP']

found here: https://github.com/danpaquin/coinbasepro-python/blob/2f28abbdeeaa60932a24a93c6a7236e09da493ca/cbpro/websocket_client.py#L68

danpaquin commented 5 years ago

Thanks for the report @jaredtkatz ! This has been resolved.

jaredtkatz commented 5 years ago

Great, glad I could help.