danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 738 forks source link

Fixed place_stop_order & made unit tests pass #372

Closed nyrv closed 3 years ago

mcardillo55 commented 3 years ago

Thanks for the PR. place_stop_order is now already resolved by #370 (I took the first PR first).

As for fixing the unit tests -- it does look like they removed the /position endpoint, which we should probably remove (both test and dead code). However, I don't think we should be replacing the test_get_position with a test on get_coinbase_accounts.

I noticed that you're testing that 'currency' exists in the get_coinbase_accounts response, which may be something to consider adding, but for now I'm going to close this.