danpaquin / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
1.82k stars 740 forks source link

Add limit price parameter for stop loss orders #451

Open benibienz opened 3 years ago

benibienz commented 3 years ago

Currently, when you create an order with place_stop_order() you create a stop limit order where the limit price is equal to the stop price.

This PR adds an optional argument limit_price to place_stop_order(), allowing the user to specify the limit as well as the stop price.

Note that our limit_price argument is equivalent to the API parameter price, whereas our price argument maps to the API parameter stop_price. This is a little confusing but I wanted to leave the default price arg of the function unchanged to maintain backwards compatibility.

mabergerx commented 2 years ago

This would be nice to have in the live version!