Approach? - Githubissues

danpaz / es-query-builder

An elasticsearch query builder.

MIT License

0 stars 0 forks source link

Closed danpaz closed 8 years ago

danpaz commented 8 years ago

@d6u What do you think of the approach?

d6u commented 8 years ago

This looks nice! But IMHO, I'm thinking one point:

Make index as part of the builder method. Instead of query = esQueryBuilder({index}), I think builder.index("index") would be more generic and flexible. Just like knex.js where method.