search

danpovey / lilcom

Small compression utility
Other
33 stars 10 forks source link

Compression fails on non-contigous feats #34

Open janvainer opened 2 years ago

janvainer commented 2 years ago

Hi, I am getting a stride error when running compression on non-contiguous tensors:

lilcom: compression error: last stride should be 1, got 253

The error message is a bit confusing and its not clear wht the problem is. Some solutions could be:

  1. warn the user that inputs should be contiguous and make the tensor contiguous or
  2. fail with a message that will tell the user to make their tensor contiguous.
csukuangfj commented 2 years ago

Does this error still exist?

danpovey commented 2 years ago

It's intended to be a warning that the user should make the tensor contiguous.