danpovey / lilcom

Small compression utility
Other
33 stars 10 forks source link

Fix installation on windows #37

Closed csukuangfj closed 2 years ago

csukuangfj commented 2 years ago

There are users of lhotse complaining that they cannot install lilcom on Windows.

This PR fixes that.

In addition to that,

The steps to publish a new version to PyPI are:

(1) Go to https://github.com/danpovey/lilcom/settings/secrets/actions and add two secrets:

After adding, you should see something like the following screenshot lilcom-1

This step only needs to be done once.

(2) Edit CMakeLists.txt: https://github.com/danpovey/lilcom/blob/12c41c703214cd41a2e00a4a786e7447efd6e392/CMakeLists.txt#L4

For instance, the current version is 1.1.1. If you want to release 1.2, just replace 1.1.1 with 1.2

git add CMakeLists.txt
git commit -m "Release v1.2"
git push
git tag v1.2
git push origin v1.2

That's it!

csukuangfj commented 2 years ago

Note: It does not change the way how lilcom would be installed. You can use

pip install lilcom

or

pip install git+https://github.com/danpovey/lilcom

or

git clone https://github.com/danpovey/lilcom
cd lilcom
python3 setup.py install
danpovey commented 2 years ago

thankyou! will do this tomorrow my time..

On Sun, Jul 3, 2022 at 11:57 PM Fangjun Kuang @.***> wrote:

Note: It does not change the way how lilcom would be installed. You can use

pip install lilcom

or

pip install git+https://github.com/danpovey/lilcom

or

git clone https://github.com/danpovey/lilcomcd lilcom python3 setup.py install

— Reply to this email directly, view it on GitHub https://github.com/danpovey/lilcom/pull/37#issuecomment-1173423790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLOZP4VHDYTVCYEY2OTDVSKDMFANCNFSM52SCB4ZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

danpovey commented 2 years ago

Thanks, I believe this is done now.