search

danpovey / pocolm

Small language toolkit for creation, interpolation and pruning of ARPA language models
Other
90 stars 48 forks source link

some minor changes to make it compatible with python 3.x #68

Closed chris920820 closed 7 years ago

nshmyrev commented 8 years ago

Its probably better to import https://pypi.python.org/pypi/six library which helps to provide python 2/3 support in consistent way. You could use xrange consistently then. Tensorflow uses it for example.

danpovey commented 7 years ago

We already discussed the 'six' library but it looks like none of the features which that library offers compatibility support for are being used anyway. So I prefer to keep things simple and not use it. There is no point being super-efficient about ranges when they are not in places that are called much-- the python script is just a wrapper for C++ which does all the slow stuff.

Dan

On Tue, Sep 20, 2016 at 4:39 AM, chris920820 notifications@github.com wrote:

Closed #68 https://github.com/danpovey/pocolm/pull/68.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danpovey/pocolm/pull/68#event-795310730, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJVu9vkqGwwVSvGDehDYP8IuvO2PfwNks5qr5vIgaJpZM4J7djU .