danpros / htmly

Simple and fast databaseless PHP blogging platform, and Flat-File CMS
https://www.htmly.com
GNU General Public License v2.0
1.07k stars 263 forks source link

Translation & language corrections #759

Closed vdbhb59 closed 4 months ago

vdbhb59 commented 4 months ago
vdbhb59 commented 4 months ago

There are still many changes left, all language based, but I did not have time to get to those. Please merge these changes, and I will pick up the rest when I can, maybe next month (not too sure). @danpros

danpros commented 4 months ago

Hello,

I think you misinterpreted it "All posts tagged X" this mean we display all posts with tag X. You change it to "All tagged posts X"

danpros commented 4 months ago

And you just need to change the .ini value and not the key so no need to edit the PHP files.

vdbhb59 commented 4 months ago

Hello,

I think you misinterpreted it "All posts tagged X" this mean we display all posts with tag X. You change it to "All tagged posts X"

Ahh my bad. 🫣 I will change it. However, it really was confusing. 🙃

For only INI, it will not work then as those INI and PHP tags should be in sync. So change is needed in both the places. I will update and correct.

danpros commented 4 months ago

Its still work because key is just the key.

Example if we have, key comments and value About in our language file:

comments = "About"

We call it in template file:

<a href=""><?php echo i18n('comments');?></a>

Than resulting HTML:

<a href="">About</a>
vdbhb59 commented 4 months ago

Its still work because key is just the key.

Example if we have, key comments and value About in our language file:

comments = "About"

We call it in template file:

<a href=""><?php echo i18n('comments');?></a>

Than resulting HTML:

<a href="">About</a>

Understood. But should the sentence construction be not correct? You can see the changes I did in all files are to correct them (other than the "all_posts_tagged", which was my misunderstanding)? Example _url_isleft; _if_leftempty/blank are the correct statement. Should I at least keep those as I changed?

danpros commented 4 months ago

Yes no problems if you want to correct it, thank you for that. Besides, it's in the admin so it doesn't matter with the existing theme. Perhaps in the future we can simplify the key, example:

by_using_this_importer_you_are_agree_if_the_feed_is_yours_or_at_least_you_have_the_authority_to_publish_it

It would be great if in the future just, eg. importer_warning etc.

vdbhb59 commented 4 months ago

Yes no problems if you want to correct it, thank you for that. Besides, it's in the admin so it doesn't matter with the existing theme. Perhaps in the future we can simplify the key, example:

by_using_this_importer_you_are_agree_if_the_feed_is_yours_or_at_least_you_have_the_authority_to_publish_it

It would be great if in the future just, eg. importer_warning etc.

True, that makes sense. Minimal is better. :)

vdbhb59 commented 4 months ago

@danpros mate, all done now. Good to go and merge. :)

danpros commented 4 months ago

Thank you! 😃