search

danpros / htmly

Simple and fast databaseless PHP blogging platform, and Flat-File CMS
https://www.htmly.com
GNU General Public License v2.0
1.1k stars 266 forks source link

Update http URLs to https in Markdown.Editor.js #819

Closed danielethanme closed 1 month ago

danielethanme commented 1 month ago

https://transparencyreport.google.com/https/overview

https://gs.statcounter.com/browser-market-share/

The majority of websites are served over https now. Updated editor so link examples show https instead of http.

Also updated the "Fixes common pasting errors" bit of js so it prepends https instead of http to the domain name.

Updated the imagedialog and imageDefaultText to https as well, but don't really see where that does anything.

Before

http-insecure-example-link

After

https-secure-example-link

Prepend https to domain names

prepend-https-example

prepend-https-example-2

danpros commented 1 month ago

Thanks for the PR. What about your previous PR #818. Seems this PR also include your previous PR. You should close the old one before I merged this.

taufik-nurrohman commented 1 month ago

Using location.protocol would make the result automatic based on your site URL.

danielethanme commented 1 month ago

@danpros Sorry about that. I'm just getting started with GitHub Desktop and was trying to separate my work in different PRs since the two PRs were updating unrelated things. I'll figure out how to do it better next time. :)

I closed PR https://github.com/danpros/htmly/pull/818 per your suggestion so this PR can be merged.

danpros commented 1 month ago

@danielethanme No problem 😃 Thanks for the PR