search

danreeves / dt-exchange

40 stars 17 forks source link

First pass support for Melk's store, quick 'n dirty dropdown #18

Closed Coconutcoo closed 1 year ago

Coconutcoo commented 1 year ago

Fixes #6

Unfortunately starting running into a real large refactor if I tried to make char and storeType required arguments, since we've got a few other things like Array.find<T>() and useSWR<T>() that return T|undefined, so I've settled by making their types specifically Character|undefined etc.

The dropdown selector for store type is really a quick fix, I have no doubt a better UI can and should be done, but at least it gets the data accessible for now.

Coconutcoo commented 1 year ago

@danreeves I think all the feedback has been solved - I also removed the 3 {" "} after each sort, since it didn't seem to visually change the page. I assume you were trying to space out the options? It was entirely removed in the actual injected html, so I think it was doing nothing.

Please lmk if there was some deeper use for them in React that I've missed and I can re-add.

danreeves commented 1 year ago

the 3 {" "} after each sort

Yeah those look unnecessary

danreeves commented 1 year ago

Just tested. works well!