danreeves / dt-exchange

40 stars 17 forks source link

Desktop notifications for user-defined criteria #19

Open Chris-Bitler opened 1 year ago

Chris-Bitler commented 1 year ago

Users who leave the page open should be able to, if they give the extension permission, get desktop notifications if an item meeting criteria they defined has appeared in the shop inventory(s).

Example filter criteria:

Base level, blessings, and perks would be a good start atleast.

errnoh commented 1 year ago

👍 will likely be next on the line for me after the shop filter branch gets merged

Chris-Bitler commented 1 year ago

👍 will likely be next on the line for me after the shop filter branch gets merged

I've actually already started work on this, if that is alright?

@danreeves Please assign this issue to me to prevent any confusion

errnoh commented 1 year ago

@Chris-Bitler oh, well. I don't mind not having to work on the notification, but the trigger logic will likely have quite large overlap with #2, which was the main reason I was planning on working on that.

danreeves commented 1 year ago

you're right, i don't know if this is ready to be worked on beyond "the ability to create notifications, generically"

Chris-Bitler commented 1 year ago

@danreeves @errnoh I can base this issue's work on #2 if that is the case - I think it should be fine to start working on it, and I can update it with changes based on what happens with @errnoh's PR. Is that OK?